Add direct download option to users in register template form#10193
Add direct download option to users in register template form#10193JoaoJandre merged 1 commit intoapache:4.20from
Conversation
|
@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.20 #10193 +/- ##
=========================================
Coverage 16.15% 16.15%
- Complexity 12976 12978 +2
=========================================
Files 5639 5639
Lines 494081 494081
Branches 59910 59910
=========================================
+ Hits 79800 79806 +6
+ Misses 405453 405446 -7
- Partials 8828 8829 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
UI build: ✔️ |
|
@lucas-a-martins , it does not seem to work in qa. I can not tell from the API if this needs a version after 4.20. Do you know? |
nvazquez
left a comment
nvazquez
left a comment
There was a problem hiding this comment.
LGTM - haven't tested it though
@DaanHoogland , I tried to test in the same QA (#10193 (comment)), but the only hypervisor option it has for normal users is "Simulator".
Even before this PR, the direct download only works if the hypervisor is KVM or |
|
@kiranchavala a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
|
@blueorangutan package |
|
@kiranchavala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12196 |
|
@lucas-a-martins do you want this on 4.20 or 21? (it is targetted to main now) |
winterhazel
left a comment
winterhazel
left a comment
There was a problem hiding this comment.
Tested locally by registering a direct download template as a normal user, and deploying a VM from the template.
@DaanHoogland 4.20 lgtm |
ok @lucas-a-martins , can you rebase it on the 4.20 branch then? It looks ready for merge otherwise. |
lucas-a-martins
force-pushed
the
add-direct-download-option-to-user-ui
branch
from
7ff7d25 to
4e1964e
Compare
Co-authored-by: Lucas Martins <lucas.martins@scclouds.com.br>
9 participants
Description
Normal users are allowed to register a direct download template via API, but the option is disabled in the UI.
This PR fix the issue #9923 by removing this restriction.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
The template registered by a normal user using the direct download option:
How Has This Been Tested?
I tested by registering a template via UI using an account with the User role. Selecting the KVM hypervisor gave me the direct download option.